Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ios audio source #36

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Feature/ios audio source #36

merged 3 commits into from
Aug 19, 2024

Conversation

tonelli-m
Copy link
Collaborator

@tonelli-m tonelli-m commented Aug 12, 2024 •
edited
Loading

Description

Adds AudioSource implementation for iOS

⚠️ This PR is built on top of #35! It should only be merged afterwards. ⚠️

Changes

  • Implements the AudioSource interface for iOS using AVAudioSession and AVAudioEngine
  • See Apple documentation for more details: AVAudioSession, AVAudioEngine

Linked issues

#34

Remaining TODOs

  • The output level seems a little high compared to the Android equivalent (same for the web version btw). I think the gain value should be platform specific (currently ANDROID_GAIN is used by default everywhere)
  • Currently the default microphone is picked up by default (same of other platforms atm), but in fine it should be possible for the user to switch microphones

Checklist

  • Code compiles correctly on all platforms
  • All pre-existing tests are passing
  • If needed, new tests have been added
  • Extended the README / documentation if necessary
  • Added code has been documented

@tonelli-m tonelli-m added KMP Shared Kotlin code iOS iOS related code labels Aug 12, 2024
@tonelli-m tonelli-m marked this pull request as draft August 13, 2024 08:29
@tonelli-m tonelli-m changed the base branch from main to dev August 13, 2024 08:31
@tonelli-m tonelli-m marked this pull request as ready for review August 19, 2024 08:48
@tonelli-m tonelli-m changed the base branch from dev to main August 19, 2024 08:51
@tonelli-m tonelli-m changed the base branch from main to dev August 19, 2024 08:51
@nicolas-f nicolas-f merged commit 8a3e7ee into dev Aug 19, 2024
6 checks passed
@nicolas-f nicolas-f deleted the feature/ios-audio-source branch August 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicolas-f nicolas-f

Labels
iOS iOS related code KMP Shared Kotlin code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonelli-m @nicolas-f