Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reflection order 2-n #693

Draft
wants to merge 13 commits into
base: 4.X
Choose a base branch
from
Draft

Fix reflection order 2-n #693

wants to merge 13 commits into from

Conversation

nicolas-f
Copy link
Member

  • Reduce the number of precomputed visibility cone of reflection (performance)
  • Fix missing reflections and attributes for order 2-n
  • Fix allocation for various cases and rename buildingHeight to obstacleAltitude as rays are using altitude not height.

TODO add unit test for reflections with high altitude DEM

@nicolas-f nicolas-f changed the base branch from main to 4.X October 11, 2024 13:07
@nicolas-f nicolas-f marked this pull request as draft October 11, 2024 13:16
@pierromond
Copy link
Contributor

What you are calling altitude, is this the Zobject ? https://noisemodelling.readthedocs.io/en/latest/Input_buildings.html
If it is the case, maybe rename buildingHeight by obstacleZ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-f @pierromond