Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update values.yaml comments to point to community images #148

Merged
merged 2 commits into from
May 29, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented May 29, 2024

As we plan to remove our passport dependencies Unleash/unleash#7159 starting from 6.0.0, the current comments in values.yaml no longer holds. Unleash will no longer include passport libraries and as such, the suggested index.js configmap will not work at all.

@chriswk chriswk self-assigned this May 29, 2024
@chriswk chriswk mentioned this pull request May 29, 2024
14 tasks
Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.
Would it be worth considering adding a reference URL? Pointing to a doc explaining this or the community repos directly.

@chriswk
Copy link
Member Author

chriswk commented May 29, 2024

I updated the community repo with a landing point. So I'll update the link to include the anchor once Unleash/unleash-docker-community#148 is merged

@chriswk
Copy link
Member Author

chriswk commented May 29, 2024

I updated the community repo with a landing point. So I'll update the link to include the anchor once Unleash/unleash-docker-community#148 is merged

✔️

@chriswk chriswk merged commit 7ec2b9c into main May 29, 2024
12 checks passed
@chriswk chriswk deleted the docs/unleashSSOCommunity branch May 29, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants