fix: clear stale errors #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
approved these changes
Nov 29, 2023
There's a test in the parent SDK testing the behavior of the event system internals. |
|
@FredrikOseberg I meant the flag clearing part only, not the underlying logic. But I leave it up to you to decide if it's worth the effort |
We could. The reason I left it out is because such a test will basically just test the setState functionality of react and event listener functionality, which is already quite heavily tested by those frameworks. |
cjcheshire
reviewed
Feb 9, 2024
| @@ -50,7 +50,7 @@ | |||
| "react-dom": "^18.2.0", | |||
| "react-test-renderer": "^18.2.0", | |||
| "typescript": "^5.3.2", | |||
| "unleash-proxy-client": "^3.2.0", | |||
| "unleash-proxy-client": "^3.3.0-beta.1", | |||
There was a problem hiding this comment.
This was missed off the changelog! :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where errors would not be cleared out and kept in state.
How
In the parent SDK we emit a 'recovered' event when the network call is successful following an errored HTTP call. In this SDK we listen to the recover event and set the error state to
null.