Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rename parameters related to feature name #156

Merged
merged 1 commit into from
Jan 9, 2024
Merged

docs: rename parameters related to feature name #156

merged 1 commit into from
Jan 9, 2024

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Jan 9, 2024

Make it more intuitive what is an expected parameter for useFlag and useVariant.

@Tymek Tymek requested a review from nnennandukwe January 9, 2024 08:59
nnennandukwe
nnennandukwe approved these changes Jan 9, 2024
View reviewed changes
Copy link

@nnennandukwe nnennandukwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!

@Tymek Tymek merged commit 13aed89 into main Jan 9, 2024
4 checks passed
@Tymek Tymek deleted the docs/rename-params branch January 9, 2024 14:05
@chambridge chambridge mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnennandukwe nnennandukwe nnennandukwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tymek @nnennandukwe