Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass own OkHttpClient to DefaultUnleash #84

Closed
vassilisimon opened this issue Sep 1, 2024 · 2 comments · Fixed by #89
Closed

Add ability to pass own OkHttpClient to DefaultUnleash #84

vassilisimon opened this issue Sep 1, 2024 · 2 comments · Fixed by #89
Assignees
@chriswk
Labels
enhancement New feature or request

Comments

@vassilisimon
Copy link

vassilisimon commented Sep 1, 2024 •
edited
Loading

Describe the feature request

Hello,

in the old unleash-proxy-sdk it was possible to pass a OkHttpClient to the UnleashClient.
This isn't possible anymore with the new sdk. It would be nice to have this ability again, as we need it so support devices with api < 23 with custom certificates.

Background

No response

Solution suggestions

No response
@vassilisimon vassilisimon added the enhancement New feature or request label Sep 1, 2024
@chriswk chriswk self-assigned this Sep 3, 2024
@chriswk
Copy link
Member

chriswk commented Sep 3, 2024

Hi @vassilisimon. Thanks for reporting this, we've added it to our todo list

@chriswk
Copy link
Member

chriswk commented Sep 18, 2024

@gastonfournier - let's have a spar on this

@gastonfournier gastonfournier mentioned this issue Sep 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriswk chriswk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ability to pass customer defined okhttp client Unleash/unleash-android
2 participants
@chriswk @vassilisimon