Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to pass customer defined okhttp client #89

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

gastonfournier
Copy link
Contributor

About the changes

Give users the ability of providing a custom okhttp client. Useful when you need to add custom SSL certificates.

We'll use the read, write and connection timeout from the configuration, so if any of those are added to the custom client we'll override those values (which are configurable).

Closes #84

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastonfournier gastonfournier merged commit 06cc4d8 into main Sep 20, 2024
2 checks passed
@gastonfournier gastonfournier deleted the add-ability-to-provide-okhttp-client branch September 20, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to pass own OkHttpClient to DefaultUnleash
2 participants