updated to use correct comparison for distinctUntilChanged #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| } else if (inFlightCall != null && !inFlightCall.isCanceled()) { | ||
| } else if (inFlightCall != null && !inFlightCall.isCanceled() && !inFlightCall.isExecuted()) { |
There was a problem hiding this comment.
Do not cancel completed requests
|
|
||
| fun getFeaturesReceivedFlow() = featuresReceivedFlow.asSharedFlow() | ||
|
|
||
| fun startWatchingContext() { | ||
| unleashScope.launch { | ||
| unleashContext.distinctUntilChanged { old, new -> old != new }.collect { |
There was a problem hiding this comment.
Values in state flow are conflated using Any.equals comparison in a similar way to distinctUntilChanged operator. It is used to conflate incoming updates to value in MutableStateFlow and to suppress emission of the values to collectors when new value is equal to the previously emitted one. State flow behavior with classes that violate the contract for Any.equals is unspecified.
| ) : Closeable { | ||
| companion object { | ||
| private const val TAG = "UnleashFetcher" | ||
| } | ||
|
|
||
| private var contextForLastFetch: UnleashContext? = null |
There was a problem hiding this comment.
Hold the last fetched so we can ignore refreshing toggles when context has change due to a sync setContext which avoids 2 fetch calls for the same context
chriswk
deleted the
96-refreshtoggles-is-not-called-after-setcontextasync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we fetch when we setContextAsync, but also make sure we don't fetch twice when we setContext (sync method).
Fix #96