New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: init encoding with false for utf8 bom #182

Merged

daveleek merged 1 commit into main from chore/api-client-streamcontent-utf8-bom-fix

Dec 8, 2023

Collaborator

daveleek commented Dec 8, 2023

Description

Fixes edge compatibility issues by disabling BOM in utf8 strings when serialized

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Local testing against edge and Unleash

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules


          chore: init encoding with false for utf8 bom

29586c1

sighphyre approved these changes

View reviewed changes

Member

sighphyre left a comment

Gosh that is subtle, nice catch!

daveleek merged commit 27f96ff into main

2 checks passed

daveleek deleted the chore/api-client-streamcontent-utf8-bom-fix branch

December 8, 2023 08:31

daveleek mentioned this pull request

fix: use stringcontent for metrics and register so we can set headers #181

Closed

9 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet