-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client identification headers #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it weird that we can overwrite unleash-client-mock. I'd expect that it's always unleash-client-dotnet. Also how do we read the real version here?
@@ -84,6 +85,8 @@ public UnleashServices(UnleashSettings settings, EventCallbackConfig eventConfig | |||
{ | |||
AppName = settings.AppName, | |||
InstanceTag = settings.InstanceTag, | |||
ConnectionId = connectionId, | |||
SdkVersion = settings.SdkVersion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwasniew don't know if this answers your questions, but the "real" header value is read here from a default implementation in UnleashSettings: https://github.com/Unleash/unleash-client-dotnet/blob/main/src/Unleash/UnleashSettings.cs#L144C31-L144C44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd fix the original versioning to follow unleash-client-dotnet:semver convention and drop the v prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one drawback is that there's a lot of existing dotnet SDKs using the v version scheme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Identification headers consistent with other Unleash SDKs.
Fixes issue/1-3275
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: