Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade: 4.0.0 release #147

Merged
merged 1 commit into from
Nov 6, 2023
Merged

upgrade: 4.0.0 release #147

merged 1 commit into from
Nov 6, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Nov 3, 2023

No description provided.

@sjaanus sjaanus merged commit 0efdcc8 into v3 Nov 6, 2023
@sjaanus sjaanus deleted the 4.0.0 branch November 6, 2023 14:24
@jameshartig
Copy link
Contributor

I think the go.mod needs to change have github.com/Unleash/unleash-client-go/v4 and does the branch need to change too? This was merged into v3.

@FredrikOseberg
Copy link
Contributor

FredrikOseberg commented Nov 17, 2023 •
edited
Loading

I think the go.mod needs to change have github.com/Unleash/unleash-client-go/v4 and does the branch need to change too? This was merged into v3.

You're right. I'll raise this internally and we'll get a fix out promptly. Thanks!

@FredrikOseberg
Copy link
Contributor

I think the go.mod needs to change have github.com/Unleash/unleash-client-go/v4 and does the branch need to change too? This was merged into v3.

@jameshartig I think we've solved this now, can you confirm when it suits you?

Best, Fredrik

@jameshartig
Copy link
Contributor

@FredrikOseberg yep! I was able to pull in v4 now and everything seems to be working. Thanks for the quick fix!!

@FredrikOseberg
Copy link
Contributor

@FredrikOseberg yep! I was able to pull in v4 now and everything seems to be working. Thanks for the quick fix!!

Amazing! Have a good weekend :)

gastonfournier added a commit that referenced this pull request Nov 20, 2023
@gastonfournier
Revert "upgrade: 4.0.0 release (#147)"
7149fa2 
This reverts commit 0efdcc8.
gastonfournier added a commit that referenced this pull request Nov 21, 2023
@gastonfournier
chore: Revert breaking changes on v3 (#149)
d950ee0 
* Revert "upgrade: 4.0.0 release (#147)"
This reverts commit 0efdcc8.

* Revert "fix: new variant hashing (#145)"
This reverts commit b863938.

* Update version
* Don't wait 10 minutes to fail on timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjaanus @jameshartig @FredrikOseberg