Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose change request config #33

Merged
merged 4 commits into from
Mar 7, 2025
Merged

Conversation

sighphyre
Copy link
Member

Exposes the APIs to get an set change request config

@@ -0,0 +1,71 @@
package client
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests

@@ -65,3 +65,6 @@ inverseOperationIds:
- getAllEnvironments
- toggleEnvironmentOff
- toggleEnvironmentOn

- getProjectChangeRequestConfig
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New APIs

@@ -63,5 +66,6 @@ inverseOperationIds:
- removeEnvironment
- getEnvironment
- getAllEnvironments
- toggleEnvironmentOff
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this, superceeded by AddEnvironmentToProject/RemoveEnvironmentFromProject

- "unleashorg/unleash-server:latest"
- "ghcr.io/ivarconr/unleash-enterprise:6.8"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've kept server support back to 5.9 but new API behaviour is needed from 6.8 :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have tests that run only when tested from a min version onward, similar to what we do for enterprise only. I think that also serves as valid documentation.

🤔

Or maybe it has to be the other way around, the terraform resource will only do something if the min version matches. Now I think it'll fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So something like this?

isEnterprise() && versionAbove(6.8)
// some test code

Copy link
Collaborator

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good!

- "unleashorg/unleash-server:latest"
- "ghcr.io/ivarconr/unleash-enterprise:6.8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have tests that run only when tested from a min version onward, similar to what we do for enterprise only. I think that also serves as valid documentation.

🤔

Or maybe it has to be the other way around, the terraform resource will only do something if the min version matches. Now I think it'll fail.

@sighphyre sighphyre merged commit c47c1ae into main Mar 7, 2025
6 checks passed
@sighphyre sighphyre deleted the feat/project-environments branch March 7, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants