feat(1-3260): store support for data traffic from a range #9127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of manually calling it in each test.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
commented
Jan 22, 2025
| @@ -55,7 +56,7 @@ export class TrafficDataUsageStore implements ITrafficDataUsageStore { | |||
| } | |||
| async exists(key: IStatTrafficUsageKey): Promise<boolean> { | |||
| const result = await this.db.raw( | |||
| `SELECT EXISTS (SELECT 1 FROM ${TABLE} WHERE | |||
| `SELECT EXISTS (SELECT 1 FROM ${TABLE} WHERE | |||
There was a problem hiding this comment.
Trailing space. Linter kept formatting it, so let's fix it.
thomasheartman
commented
Jan 22, 2025
Tymek
reviewed
Jan 22, 2025
Tymek
approved these changes
Jan 22, 2025
thomasheartman
deleted the
feat(1-3260)/store-support-for-data-traffic-range
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for querying the traffic data usage store for the aggregated data for an arbitrary number of months back.
Adds a new
getTrafficDataForMonthRange(monthsBack: number)method to the store that aggregates data on a monthly basis by status code and traffic group. Returns a new type with month data instead of day data.