Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show a dialog when adding a release plan to a change request enabled feature environment #9139

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

daveleek
Copy link
Contributor

@daveleek daveleek commented Jan 23, 2025

Displays a dialogue for user to confirm adding changes to draft when user adds release-plan to change request enabled feature environment.

Currently does nothing more than display a success toast when confirmed, pending remaining change request implementation

image

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 0:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 0:41am

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@daveleek daveleek requested a review from nunogois January 23, 2025 08:34
Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by this. I think this is the first dialog based on a route on our whole codebase. But if it helps you keep moving forward, it should be okay for now.

…Menu/FeatureReleasePlanCard/FeatureReleasePlanCard.tsx

Co-authored-by: Nuno Góis <[email protected]>
@daveleek daveleek merged commit 7aefc57 into main Jan 23, 2025
11 checks passed
@daveleek daveleek deleted the feat/add-release-plan-changerequest-dialog branch January 23, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants