Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore website docs generated in biome #9168

Merged
merged 3 commits into from
Jan 29, 2025
Merged

chore: ignore website docs generated in biome #9168

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e8937
chore: bump biome files maxSize
nunogois Jan 29, 2025
8300985
chore: add website docs generated to the ignore list
nunogois Jan 29, 2025
04ecbc0
chore: remove maxSize
nunogois Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
"files": {
"maxSize": 2097152
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it safe to increase it for SEO/WebPerf?

Copy link
Member Author

@nunogois nunogois Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding the generated folder to the ignore lists we no longer need this, so I'm removing it. I don't expect this to impact SEO/WebPerf at all, it's just a sane limit that Biome has by default to not load large files. See: https://biomejs.dev/reference/configuration/#filesmaxsize

},
"linter": {
"enabled": true,
"rules": {
Expand Down Expand Up @@ -49,6 +52,7 @@
"docker",
"bundle.js",
"website/build",
"website/docs/generated",
"website/global.js",
"setupJest.js",
"dist",
Expand Down Expand Up @@ -79,6 +83,7 @@
"src/test/examples/*.json",
"coverage",
"website/build",
"website/docs/generated",
"website/global.js",
".docusaurus",
"./package.json",
Expand Down