Skip to content

Commit

Permalink
fix: move wasm engine to handle featureEnabled not feature_enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
sighphyre committed Oct 22, 2024
1 parent efedfe2 commit 872e1cb
Showing 1 changed file with 25 additions and 7 deletions.
32 changes: 25 additions & 7 deletions yggdrasilwasm/e2e-tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,20 @@ type VariantTest = BaseTest & {
expectedResult: Record<string, unknown>
}

type VariantResponse = {
featureEnabled: boolean,
payload: Record<string, string>,
enabled: boolean,
name: string
}

type LegacyVariantResponse = {
feature_enabled: boolean,
payload: Record<string, string>,
enabled: boolean,
name: string
}

type TestSuite = {
state: Record<string, unknown>
tests: ToggleTest[]
Expand All @@ -26,9 +40,9 @@ const DISABLED_VARIANT = {
enabled: false
}

const getDisabledVariant = (feature_enabled: boolean) => ({
const getDisabledVariant = (featureEnabled: boolean) => ({
...DISABLED_VARIANT,
feature_enabled
featureEnabled
})

type Response = {
Expand Down Expand Up @@ -84,7 +98,8 @@ describe('Client Spec Tests', () => {

for (const variantTest of variantTests) {
const toggleName = variantTest.toggleName
const expectedResult = JSON.stringify(variantTest.expectedResult)
const expectedResult = variantTest.expectedResult as any as LegacyVariantResponse;


test(`Variant Test: ${variantTest.description}`, () => {
const variantResponse = engine.checkVariant(
Expand All @@ -99,14 +114,17 @@ describe('Client Spec Tests', () => {
undefined
)

const feature_enabled =
const featureEnabled =
extractResult<boolean>(toggleResponse) ?? false

const result =
extractResult(variantResponse) ??
getDisabledVariant(feature_enabled)
extractResult<VariantResponse>(variantResponse) ??
getDisabledVariant(featureEnabled)

expect(JSON.stringify(result)).toBe(expectedResult)
expect(result.name).toBe(expectedResult.name);
expect(result.enabled).toBe(expectedResult.enabled);
expect(result.featureEnabled).toBe(expectedResult.feature_enabled);
expect(result.payload).toEqual(expectedResult.payload);
})
}
})
Expand Down

0 comments on commit 872e1cb

Please sign in to comment.