chore: implement wasm engine #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nunogois
commented
Sep 16, 2024
chriswk
approved these changes
Sep 17, 2024
sighphyre
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2640/create-a-wasm-layer-that-has-feature-parity-with-our-ffi-layer
Implements the WASM engine, using the FFI layer as reference. Updates the tests accordingly.
I opted to use a
Responseobject, like we do in the FFI layer. This should provide us with a very consistent behavior, whether you use the FFI layer or the WASM engine. We can then parse theseResponseobjects in our wrapper and handle them accordingly.All our client spec tests are currently passing: https://github.com/Unleash/yggdrasil/actions/runs/10888640435/job/30213559806?pr=143#step:9:225