feat: list known features #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonfournier
approved these changes
Oct 29, 2024
|
|
||
| public string Project { get; set; } | ||
|
|
||
| public string? Type { get; set; } |
There was a problem hiding this comment.
Is the type optional?
There was a problem hiding this comment.
Yeeeaa... maybe. This is a good question. I've derived the type here from the types defined in our core Unleash Types rust library, which says this is optional. As for the actual question. I don't think this is optional in modern versions of Unleash but it's non existent in older versions. Not sure how far we back we have to go but there's at least one set of humans using Unleash v3 and I just haven't checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a very simple way to list the features known to the engine at the time of calling. This is to support SDKs like .NET/Go/Java which have a current option to list the features and is typically used to iterate those features and evaluate them all. For the consuming code, this produces a list of objects that look like
{
"name" "The name of the feature toggle",
"project": "The project the feature belongs to",
"type": "Experiment, kill switch, etc, only sent if the feature response includes this, some older formats don't"
}
Currently only implemented in the FFI layers for Ruby and .NET.