Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch 500 error for fast strategy #316

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

Coniferish
Copy link
Collaborator

@Coniferish Coniferish commented Nov 25, 2023

Closes #314

We don't support any fallback for fast strategy on images anymore, and unst will raise value error if partition uses fast strategy for image files. This catches the error and raises a 400 HTTPException.

Also, this refactors pipeline_api to extract out some validation of arguments.

@Coniferish Coniferish changed the title Jj/314 catch 500 error for fast strategy catch 500 error for fast strategy Nov 25, 2023
@Coniferish Coniferish marked this pull request as ready for review November 26, 2023 01:06
@Coniferish Coniferish requested a review from awalker4 November 26, 2023 01:06
Copy link
Collaborator

@awalker4 awalker4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks great!

@awalker4 awalker4 merged commit c5f7119 into main Nov 28, 2023
@awalker4 awalker4 deleted the jj/314-catch-500-error-for-fast-strategy branch November 28, 2023 14:58
Copy link

sentry-io bot commented Nov 28, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: negative seek value -1 /general/v0/general View Issue
  • ‼️ AttributeError: 'NullObject' object has no attribute 'get' /general/v0/general View Issue
  • ‼️ OptionError: No such keys(s): 'io.excel.zip.reader' /general/v0/general View Issue
  • ‼️ UnknownModelException: Unknown model type: yolox_quantized--pdf-infer-table-structure /general/v0/general View Issue
  • ‼️ TypeError: invalid length: 6 /general/v0/general View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catch 500 error and return to users when using fast strategy for images
2 participants