Refactor

client/actions/update_table.py

@@ -17,6 +17,29 @@
 
 
 class UpdateTable(QAction):
+    def _on_selection_change(self):
+        """Update the metadata when a new row is selected.
+
+        This method is called when the selection in the table changes.
+        """
+
+        # Get the primary key from the first column (assume first column is the pk)
+        key: int = self.parent().selected_row()[0]
+
+        # Each item has a different metadata format; use the current table to method
+        metadata: tuple[tuple[any], list[str]]
+        if self.parent().current_table() == "project":
+            metadata = self.parent().db_view.get_project_metadata(key)
+        elif self.current_table() == "scan":
+            metadata = self.parent().db_view.get_scan_metadata(key)
+        elif self.current_table() == '"user"':
+            metadata = self.parent().db_view.get_user_metadata(key)
+        else:
+            raise NotImplementedError(f"Unknown table {self.parent().current_table()}")
+
+        # Update the metadata panel with the new metadata
+        self.parent().metadata_panel.update_metadata(metadata)
+
     def _update_table(self) -> None:
         """Update table model using SQL command.
 
@@ -80,7 +103,7 @@ def _update_table(self) -> None:
 
         # Make the table react to selection changes
         self.parent().table_view.selectionModel().selectionChanged.connect(
-            self.parent().on_selection_changed
+            self._on_selection_change
         )
 
         # Let user sort table by column

client/gui.py

@@ -246,23 +246,3 @@ def selected_row(self) -> tuple[Any, ...]:
         row: tuple[Any] = self.table_model.get_row_data(row_index)
 
         return row
-
-    def on_selection_changed(self) -> None:
-        """Update the metadata when a new row is selected."""
-
-        # Get the primary key from the first column (assume first column is the pk)
-        key: int = self.selected_row()[0]
-
-        # Each item has a different metadata format; use the current table to method
-        metadata: tuple[tuple[any], list[str]]
-        if self.current_table() == "project":
-            metadata = self.db_view.get_project_metadata(key)
-        elif self.current_table() == "scan":
-            metadata = self.db_view.get_scan_metadata(key)
-        elif self.current_table() == '"user"':
-            metadata = self.db_view.get_user_metadata(key)
-        else:
-            raise NotImplementedError(f"Unknown table {self.current_table()}")
-
-        # Update the metadata panel with the new metadata
-        self.metadata_panel.update_metadata(metadata)

client/runners/generic.py

@@ -1,6 +1,7 @@
 """
 Generic worker class for running jobs in a separate thread.
 """
+from __future__ import annotations
 
 import logging
 import sys

client/settings/__init__.py

@@ -1,6 +1,8 @@
 """
 Base settings.
 """
+from __future__ import annotations
+
 from functools import wraps
 from pathlib import Path
 from typing import TYPE_CHECKING, Any

client/utils/hash.py

@@ -1,6 +1,7 @@
 """
 File hashing algorithms.
 """
+from __future__ import annotations
 
 from hashlib import sha3_384
 from typing import TYPE_CHECKING

client/widgets/dialogue/create_prj.py

@@ -2,6 +2,7 @@
 This window lets a user input and create a new project, which is added to the database
 specified by the input connection string.
 """
+from __future__ import annotations
 
 import logging
 from pathlib import Path

client/widgets/dialogue/download_scan.py

@@ -1,6 +1,8 @@
 """
 Progress bar dialogue for downloading the scan.
 """
+from __future__ import annotations
+
 import logging
 from typing import TYPE_CHECKING
 

client/widgets/table/model.py

@@ -11,6 +11,7 @@
 the type hints from the base class even though they are incorrect. This does not affect
 the runtime behaviour of the code.
 """
+from __future__ import annotations
 
 from datetime import date, datetime
 from typing import TYPE_CHECKING, Any

client/widgets/thumbnail/widget.py

@@ -3,6 +3,8 @@
 """
 
 
+from __future__ import annotations
+
 from typing import TYPE_CHECKING
 
 from PySide6.QtCore import QSize, Qt
@@ -18,8 +20,8 @@
 class Thumbnail(QFrame):
     """A widget that scales an image to fill a box while maintaining aspect ratio."""
 
-    def __init__(self) -> None:
-        super().__init__()
+    def __init__(self, *args, **kwargs) -> None:
+        super().__init__(*args, **kwargs)
 
         # Use a layout to prevent the image from being stretched
         layout: QVBoxLayout = QVBoxLayout()