Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vps 45/daisy UI tabs #265

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Vps 45/daisy UI tabs #265

merged 5 commits into from
Oct 21, 2024

Conversation

laibatool792
Copy link
Contributor

Describe the issue

The previous resources modal had MUI designing. Shown below.

Screenshot 2024-10-20 at 7 34 36 PM

Describe the solution

Switched to Daisy UI tabs for a better visual appeal and for integration with the rest of the code base as UI elements are being switched to daisyUI.

Screenshot 2024-10-20 at 7 43 53 PM

Risk

Potentially active CSS not showing properly

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Contributor

@harbassan harbassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I don't think we ever actually implemented that top design lol

@harbassan harbassan merged commit bae6a99 into master Oct 21, 2024
5 checks passed
@harbassan harbassan deleted the VPS-45/daisy-ui-tabs branch October 21, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants