feat: enhanced turbo-train-stream-source JS API #11
+100
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added next public JS API:
init
method - allows to initEventSource
destroy
method - allows to destroyEventSource
state
getter - returns humanized version ofEventSource.readyState
no-turbo-stream
param - to not callTurbo.connectStreamSource
when it's not neededAdded proxy for
EventSource
events:open
message
error
So client JS doesn't need to access private
#eventSource
field.Didn't implement reconnection logic inside component - as reconnection strategy might vary from case to case.
An example of reconnection strategy on client side:
Side fix
Remove
node_modules
from version control