Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue caused from bad merge #68

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Resolved issue caused from bad merge #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18bb2c4
resolved issue caused from bad merge
matthewnitschke Apr 7, 2024
8451dc7
removed no longer valid comment
matthewnitschke Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions queries/highlights.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
; --------------------
(super) @function

; TODO: add method/call_expression to grammar and
; distinguish method call from variable access
Comment on lines -7 to -8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was resolved in #65, just cleaning up the comment accordingly

(function_expression_body
(identifier) @function)

Expand Down Expand Up @@ -99,10 +97,6 @@
(identifier) @function)
(setter_signature
name: (identifier) @function)
(enum_declaration
name: (identifier) @type)
(enum_constant
name: (identifier) @method)
Comment on lines -102 to -105
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were duplicated, actual definition is lower: https://github.com/UserNobody14/tree-sitter-dart/pull/68/files#diff-d485a982e458ef8da2cc203585065b7542665cb80b78d230b1e8f77ea25825d4L117

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks didn't notice the move

(type_identifier) @type

((scoped_identifier
Expand Down