Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: orcid lowercasing done #464

Closed
wants to merge 1 commit into from
Closed

Conversation

yoganandaness
Copy link
Contributor

@yoganandaness yoganandaness commented Oct 31, 2024

Description

In the Visa connector, when creating experiment users, lower the case of orcid and email before saving into the users table

Motivation and Context

During the Visa login, which is using keycloack, the username is being lowercased. However, the username from the user office proposal doesnt. Due to this, the logged in user could not see their corresponding proposals. This can be fixed by lowercasing the username during the acceptance of the proposal

How Has This Been Tested

Manual

Fixes

User not able to see their proposal in the Visa

Changes

Added a sanitizing function, that transforms the entire payload based on the requirements.

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

Summary by Sourcery

Lowercase ORCID and email addresses in proposal messages to ensure consistency and fix visibility issues for users.

Bug Fixes:

  • Fix issue where users could not see their proposals by lowercasing ORCID and email addresses before saving them.

Enhancements:

  • Add a sanitizing function to transform the proposal message payload by lowercasing ORCID and email addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants