fix: handle the deletion of subtemplate answers #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepaksftc
changed the title
deepaksftc
requested review from
a team and
CarinaLobley
and removed request for
a team
bolmsten
requested review from
yoganandaness
and removed request for
CarinaLobley
deepaksftc
force-pushed
the
1261-dev
branch
2 times, most recently
from
4225f6b to
68a1ced
Compare
mutambaraf
reviewed
Jan 28, 2025
mutambaraf
reviewed
Jan 28, 2025
mutambaraf
reviewed
Jan 28, 2025
mutambaraf
reviewed
Jan 28, 2025
mutambaraf
approved these changes
Jan 29, 2025
yoganandaness
requested changes
Jan 30, 2025
yoganandaness
requested changes
Jan 30, 2025
|
|
||
| unsatisfiedDependencyQues.forEach(async (subTemplateQues) => { | ||
| const config = subTemplateQues.config as SubTemplateConfig; | ||
| await this.deleteSubTemplatesAnswers( |
There was a problem hiding this comment.
This will not be awaited, because forEach does not await the function body statements.
Maybe use Promise.all with map or a for ... of
This might now show as a problem if you do not expect immediate update latter in the code.
| return; | ||
| } | ||
|
|
||
| genericTemplates.forEach(async (genericTemplate) => { |
There was a problem hiding this comment.
The same issue with the await is here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a fix to clear the answers of dependent generic template questions when their conditions are not satisfied.
Motivation and Context
The change is required to maintain the integrity of the data and avoid any confusion or misinformation due to the persistence of answers that are no longer relevant or correct. This improves the user experience and ensures the accuracy of the information presented to the users.
Changes
deleteOldAnswersfunction to includeanswersandagentparameters to better handle the deletion process.deleteSubTemplatesAnswersfunction to handle the deletion of subtemplate answers when their parent question's conditions are not met.How Has This Been Tested?
Fixes Issue
UserOfficeProject/issue-tracker#1261
Depends On
Tests included/Docs Updated?