Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw testing/pre texas comp 2 17 25 #123

Merged
merged 99 commits into from
Feb 18, 2025

Conversation

MaxxWilson
Copy link
Collaborator

PR Summary

PR Link: INSERT-LINK-HERE

Issue Link: INSERT-LINK-HERE

Description

Add a single line summary describing the purpose of this PR.

Reviewers

Tag reviewers.

  • Required:

  • Optional:


Changelog

  • Add a bulleted list of major changes

Reviewer Guide

This is the most important part!

  • No one is going to read every line of every PR, so you need to tell the reviewers what they are looking for.
  • Point out lines you want feedback on or feel unsure about.
  • Highlight major changes that other members need to know about.

Testing

Automatic

  • Describe test cases that are covered by unit tests

Manual

  • Describe any manual testing (launch files, visualizations, etc.)

Documentation

  • Link any relevant documentation

Checklist

  • Confirmed all tests pass on a clean build
  • Added reviewers in Github
  • Posted PR Summary to Discord PR's Channel
  • Ran uncrustify on any modified C++ files
  • Ran Colcon Lint for any modified CMakeLists.txt or Package.xml

JakeWendling and others added 30 commits August 23, 2024 16:47
# PR Summary
PR Link: INSERT-LINK-HERE

Issue Link: INSERT-LINK-HERE

### Description
Add a single line summary describing the purpose of this PR.

### Reviewers
Tag reviewers.

- Required:
  
- Optional:

---
### Changelog
- Add a bulleted list of major changes

### Reviewer Guide
This is the most important part!
- No one is going to read every line of every PR, so you need to tell
the reviewers what they are looking for.
- Point out lines you want feedback on or feel unsure about.
- Highlight major changes that other members need to know about.

### Testing
#### Automatic
- Describe test cases that are covered by unit tests
#### Manual
- Describe any manual testing (launch files, visualizations, etc.)

### Documentation
- Link any relevant documentation

### Checklist
- [ ] Confirmed all tests pass on a clean build
- [ ] Added reviewers in Github
- [ ] Posted PR Summary to Discord PR's Channel
- [ ] Ran uncrustify on any modified C++ files
- [ ] Ran Colcon Lint for any modified CMakeLists.txt or Package.xml
removes odom prints
lidar data does not align well with predicted scan
xwilson03 and others added 27 commits February 15, 2025 15:07
fixes warning in particle filter node
removes -r flag and checks directly for pros
adds pip and setuptools version to dependency update
disables failing unit test :/
change test output to be more desciptive
reorganize and confirm intake motors
fixes button mapping
removes ff torque gain
disables other nodes to determine whos lying
Copy link
Collaborator

@JakeWendling JakeWendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakeWendling JakeWendling merged commit aeb6f72 into develop Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants