-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speaker support #127
Merged
Merged
speaker support #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
good move to pose both tested on hardware
adds intake hook rejection
…-GHOST/VEXU_GHOST into hw-test/move-to-pose-tuning-2-18-25
…-GHOST/VEXU_GHOST into hw-test/move-to-pose-tuning-2-18-25
…-GHOST/VEXU_GHOST into hw-test/move-to-pose-tuning-2-18-25
…-GHOST/VEXU_GHOST into hw-test/move-to-pose-tuning-2-18-25
reenables full field map tweaks the one behavior thats biased left
MaxxWilson
reviewed
Mar 2, 2025
MaxxWilson
reviewed
Mar 2, 2025
0d95027
to
1dfee94
Compare
8155e1d
to
da5eeda
Compare
JakeWendling
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm..................
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Link: INSERT-LINK-HERE
Issue Link: INSERT-LINK-HERE
Description
Add a single line summary describing the purpose of this PR.
Reviewers
Tag reviewers.
Required: @JakeWendling
Optional:
Changelog
Reviewer Guide
this shouldn't break anything. The speaker code isn't written safely cuz it's a seperate node so even if it breaks we don't care
Testing
Automatic
no
Manual
PXL_20250306_071930447.TS.mp4
Documentation
no
Checklist