e2e: add screenshot state custom height #8246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/vkui/src/components/Cell/__image_snapshots__/cell-android-chromium-dark-1-snap.png # packages/vkui/src/components/Cell/__image_snapshots__/cell-android-chromium-light-1-snap.png # packages/vkui/src/components/Cell/__image_snapshots__/cell-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/Cell/__image_snapshots__/cell-vkcom-chromium-light-1-snap.png # packages/vkui/src/components/CellButton/__image_snapshots__/cellbutton-android-chromium-dark-1-snap.png # packages/vkui/src/components/CellButton/__image_snapshots__/cellbutton-android-chromium-light-1-snap.png # packages/vkui/src/components/CellButton/__image_snapshots__/cellbutton-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/CellButton/__image_snapshots__/cellbutton-vkcom-chromium-light-1-snap.png # packages/vkui/src/components/MiniInfoCell/__image_snapshots__/miniinfocell-android-chromium-dark-1-snap.png # packages/vkui/src/components/MiniInfoCell/__image_snapshots__/miniinfocell-android-chromium-light-1-snap.png # packages/vkui/src/components/MiniInfoCell/__image_snapshots__/miniinfocell-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/MiniInfoCell/__image_snapshots__/miniinfocell-vkcom-chromium-light-1-snap.png # packages/vkui/src/components/RichCell/RichCell.e2e-playground.tsx # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-android-chromium-dark-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-android-chromium-light-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-ios-webkit-dark-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-ios-webkit-light-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-vkcom-chromium-light-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-vkcom-firefox-dark-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-vkcom-firefox-light-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-vkcom-webkit-dark-1-snap.png # packages/vkui/src/components/RichCell/__image_snapshots__/richcell-vkcom-webkit-light-1-snap.png # packages/vkui/src/components/SimpleCell/__image_snapshots__/simplecell-android-chromium-dark-1-snap.png # packages/vkui/src/components/SimpleCell/__image_snapshots__/simplecell-android-chromium-light-1-snap.png # packages/vkui/src/components/SimpleCell/__image_snapshots__/simplecell-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/SimpleCell/__image_snapshots__/simplecell-vkcom-chromium-light-1-snap.png
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8246 +/- ##
==========================================
+ Coverage 95.53% 95.54% +0.01%
==========================================
Files 404 404
Lines 11553 11920 +367
Branches 3836 4039 +203
==========================================
+ Hits 11037 11389 +352
- Misses 516 531 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
approved these changes
Feb 12, 2025
👀 Docs deployed
Commit 48d0399 |
EldarMuhamethanov
deleted the
e.muhamethanov/screenshots-custom-height
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Проблема
В текущей реализации скриншотных тестов состояния компонентов располагаются вертикально друг под другом. При изменении высоты одного из состояний все нижележащие состояния сдвигаются, что затрудняет анализ
diff'аи выявление конкретных изменений.Решение
Добавлена возможность явно задавать фиксированную высоту для состояний компонента на скриншоте через свойство
componentStateHeight.Особенности реализации
componentStateHeightпредставляет собой мапуPlatformType->numbercomponentStateHeightне указан, высота не ограничивается (поведение остается прежним)Плюсы и минусы решения
diff'апри измененияхRelease notes