general: go version 1.16 -> 1.21

.github/workflows/linter.yml

@@ -11,10 +11,10 @@ jobs:
       - name: Fetch Sources
         uses: actions/checkout@v4
 
-      - name: Set up Go 1.16
+      - name: Set up Go 1.21
         uses: actions/setup-go@v5
         with:
-          go-version: 1.16
+          go-version: 1.21
 
       - name: Run Linter
         run: make lint

.github/workflows/tests.yml

@@ -20,10 +20,10 @@ jobs:
       - name: Fetch Sources
         uses: actions/checkout@v4
 
-      - name: Set up Go 1.16
+      - name: Set up Go 1.21
         uses: actions/setup-go@v5
         with:
-          go-version: 1.16
+          go-version: 1.21
 
       - name: Run Tests
         run: make test

docs/install.md

@@ -73,13 +73,13 @@ noverify version
 
 You're done! Proceed to the [Getting started](/docs/getting_started.md) page.
 
-## With `go get`
+## With `go install`
 
 Make sure you have [Go](https://golang.org/dl/) version 1.16 or higher installed.  
 Run the following command:
 
 ```shell
-$ go get github.com/VKCOM/noverify
+$ go install github.com/VKCOM/noverify@latest
 ```
 
 NoVerify will be installed to `$GOPATH/bin/noverify`, which usually expands to `$HOME/go/bin/noverify`.

go.mod

@@ -1,11 +1,11 @@
 module github.com/VKCOM/noverify
 
-go 1.16
+go 1.21
 
 require (
 	github.com/VKCOM/php-parser v0.8.0-rc.2.0.20210802093708-d85f5a481602
 	github.com/client9/misspell v0.3.4
-	github.com/google/go-cmp v0.5.3
+	github.com/google/go-cmp v0.6.0
 	github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00
 	github.com/quasilyte/regex/syntax v0.0.0-20200419152657-af9db7f4a3ab
 	go.lsp.dev/uri v0.3.0

go.sum

@@ -3,8 +3,8 @@ github.com/VKCOM/php-parser v0.8.0-rc.2.0.20210802093708-d85f5a481602/go.mod h1:
 github.com/client9/misspell v0.3.4 h1:ta993UF76GwbvJcIo3Y68y/M3WxlpEHPWIGDkJYwzJI=
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
-github.com/google/go-cmp v0.5.3 h1:x95R7cp+rSeeqAMI2knLtQ0DKlaBhv2NrtrOvafPHRo=
-github.com/google/go-cmp v0.5.3/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
+github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
+github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 h1:n6/2gBQ3RWajuToeY6ZtZTIKv2v7ThUy5KKusIT0yc0=
 github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00/go.mod h1:Pm3mSP3c5uWn86xMLZ5Sa7JB9GsEZySvHYXCTK4E9q4=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
@@ -15,7 +15,6 @@ github.com/quasilyte/regex/syntax v0.0.0-20200419152657-af9db7f4a3ab/go.mod h1:r
 github.com/yookoala/realpath v1.0.0/go.mod h1:gJJMA9wuX7AcqLy1+ffPatSCySA1FQ2S8Ya9AIoYBpE=
 go.lsp.dev/uri v0.3.0 h1:KcZJmh6nFIBeJzTugn5JTU6OOyG0lDOo3R9KwTxTYbo=
 go.lsp.dev/uri v0.3.0/go.mod h1:P5sbO1IQR+qySTWOCnhnK7phBx+W3zbLqSMDJNTw88I=
-golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 gotest.tools v2.2.0+incompatible h1:VsBPFP1AI068pPrMxtb/S8Zkgf9xEmTLJjfM+P5UIEo=
 gotest.tools v2.2.0+incompatible/go.mod h1:DsYFclhRJ6vuDpmuTbkuFWG+y2sxOXAzmJt81HFBacw=

src/cmd/stat/go.mod

@@ -1,6 +1,6 @@
 module stat
 
-go 1.16
+go 1.21
 
 require (
 	github.com/VKCOM/noverify v0.4.0

src/linter/cache.go

@@ -17,41 +17,42 @@ import (
 //
 // Version log:
 //
-//	27 - added Static field to meta.FuncInfo
-//	28 - array type parsed as mixed[]
-//	29 - updated type inference for ClassConstFetch
-//	30 - resolve ClassConstFetch to a wrapped type string
-//	31 - fixed plus operator type inference for arrays
-//	32 - replaced Static:bool with Flags:uint8 in meta.FuncInfo
-//	33 - support parsing of array<k,v> and list<type>
-//	34 - support parsing of ?ClassName as "ClassName|null"
-//	35 - added Flags:uint8 to meta.ClassInfo
-//	36 - added FuncAbstract bit to FuncFlags
-//	     added FuncFinal bit to FuncFlags
-//	     added ClassFinal bit to ClassFlags
-//	     FuncInfo now stores original function name
-//	     ClassInfo now stores original class name
-//	37 - added ClassShape bit to ClassFlags
-//	     changed meta.scopeVar bool fields representation
-//	38 - replaced TypesMap.immutable:bool with flags:uint8.
-//	     added mapPrecise flag to mark precise type maps.
-//	39 - added new field Value in ConstantInfo
-//	40 - changed string const value storage (no quotes)
-//	41 - const-folding affected const definition values
-//	42 - bool-typed consts are now stored in meta info
-//	43 - define'd const values stored in cache
-//	44 - rename ConstantInfo => ConstInfo
-//	45 - added Mixins field to meta.ClassInfo
-//	46 - changed the way of inferring the return type of functions and methods
-//	47 - forced cache version invalidation due to the #921
-//	48 - renamed meta.TypesMap to types.Map; this affects gob encoding
-//	49 - for shape, names are now generated using the keys that make up this shape
-//	50 - added Flags field for meta.PropertyInfo
-//	51 - added anonymous classes
-//	52 - renamed all PhpDoc and Phpdoc with PHPDoc
-//	53 - added DeprecationInfo for functions and methods and support for some attributes
-//	54 - forced cache version invalidation due to the #1165
-const cacheVersion = 54
+//		27 - added Static field to meta.FuncInfo
+//		28 - array type parsed as mixed[]
+//		29 - updated type inference for ClassConstFetch
+//		30 - resolve ClassConstFetch to a wrapped type string
+//		31 - fixed plus operator type inference for arrays
+//		32 - replaced Static:bool with Flags:uint8 in meta.FuncInfo
+//		33 - support parsing of array<k,v> and list<type>
+//		34 - support parsing of ?ClassName as "ClassName|null"
+//		35 - added Flags:uint8 to meta.ClassInfo
+//		36 - added FuncAbstract bit to FuncFlags
+//		     added FuncFinal bit to FuncFlags
+//		     added ClassFinal bit to ClassFlags
+//		     FuncInfo now stores original function name
+//		     ClassInfo now stores original class name
+//		37 - added ClassShape bit to ClassFlags
+//		     changed meta.scopeVar bool fields representation
+//		38 - replaced TypesMap.immutable:bool with flags:uint8.
+//		     added mapPrecise flag to mark precise type maps.
+//		39 - added new field Value in ConstantInfo
+//		40 - changed string const value storage (no quotes)
+//		41 - const-folding affected const definition values
+//		42 - bool-typed consts are now stored in meta info
+//		43 - define'd const values stored in cache
+//		44 - rename ConstantInfo => ConstInfo
+//		45 - added Mixins field to meta.ClassInfo
+//		46 - changed the way of inferring the return type of functions and methods
+//		47 - forced cache version invalidation due to the #921
+//		48 - renamed meta.TypesMap to types.Map; this affects gob encoding
+//		49 - for shape, names are now generated using the keys that make up this shape
+//		50 - added Flags field for meta.PropertyInfo
+//		51 - added anonymous classes
+//		52 - renamed all PhpDoc and Phpdoc with PHPDoc
+//		53 - added DeprecationInfo for functions and methods and support for some attributes
+//		54 - forced cache version invalidation due to the #1165
+//	 55 - updated go version 1.16 -> 1.21
+const cacheVersion = 55
 
 var (
 	errWrongVersion = errors.New("Wrong cache version")

src/linter/cache_test.go

@@ -148,8 +148,8 @@ main();
 		// 1. Check cache contents length.
 		//
 		// If cache encoding changes, there is a very high chance that
-		// encoded data length will change as well.
-		wantLen := 5953
+		// encoded data lengh will change as well.
+		wantLen := 5952
 		haveLen := buf.Len()
 		if haveLen != wantLen {
 			t.Errorf("cache len mismatch:\nhave: %d\nwant: %d", haveLen, wantLen)
@@ -158,7 +158,7 @@ main();
 		// 2. Check cache "strings" hash.
 		//
 		// It catches new fields in cached types, field renames and encoding of additional named attributes.
-		wantStrings := "df69cfe531807fe5e317e5f894ac1ad2a68020edf03a053a30b25c70488b741b6d992d37e7a76ac4b8a760756631ee9ae309ba57e29253ffae896c3492b90939"
+		wantStrings := "690e77c94ecdd7878de0bf6f6881d786cf1fafa4588f7905f54d700646c4952aad359008ae2dcddb1c7f29163ecee62355d525672090ac30257bc414f690006f"
 		haveStrings := collectCacheStrings(buf.String())
 		if haveStrings != wantStrings {
 			t.Errorf("cache strings mismatch:\nhave: %q\nwant: %q", haveStrings, wantStrings)