WebXR Support #49
Open
WebXR Support #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this version I added WebXR SDK compatibility.
Added auto-create WebXRManager and WebXRControllers.
I added comments to the code to explain what it does.
I removed unused script that I created
Updated UxrWebXRControllerInput.cs, fixed issue if WebXR is not installed
|
Thanks for such an amazing contribution, having WebXR support is insane! Thanks again! |
|
We're currently finishing version 1.0 and will switch to GitHub for internal development too. We expect to merge this into 1.0 during December. Hang in there! :) |
|
Wow, I saw what you were doing for the new release and I am excited about this. I want to use the new version of UltimateXR soon. Will be insane that you'll use my pull request. |
|
There's a portion of this commit that's fairly important for my project, specifically the fact that you can't build for WebGL since the "Microphone" class is not available when the UNITY_WEBGL symbol is active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this pull request to add WebXR support to Ultimate XR. I tried to maintain the same programming structure without affecting anything. I had to modify the Avatar prefab to include the necessary scripts for WebXR and add a script that uses the Microphone class, which doesn't exist in the WebGL platform. The idea is to install the WebXR package from de-panther, which can be found at https://openupm.com/packages/com.de-panther.webxr/.
To make it work, you'll need to install that package, import the WebXR templates it provides, and export for WebGL.