Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: migrate to eslint #8702

Merged
merged 7 commits into from
Dec 23, 2023
Merged

style: migrate to eslint #8702

merged 7 commits into from
Dec 23, 2023

Conversation

Foo-x
Copy link
Contributor

@Foo-x Foo-x commented Oct 29, 2023

What this PR does / why we need it:

  • install eslint
  • create eslint config with npx tslint-to-eslint-config
    • ignored some rules to conform to current code
  • update existing config
    • npm scripts
    • vscode extensions
  • fix code to satisfy the rules
  • uninstall tslint
  • remove tslint.json

Which issue(s) this PR fixes

Closes #4483

Special notes for your reviewer:

I have ignored some lines difficult to immediately satisfy the eslint rules by eslint-disable-next-line.

@Foo-x Foo-x force-pushed the 4483-migrate-to-eslint branch from 08386b9 to d1fde9b Compare October 30, 2023 14:30
J-Fields
J-Fields approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@J-Fields J-Fields merged commit d712063 into VSCodeVim:master Dec 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Fields J-Fields J-Fields approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from tslint to eslint
2 participants
@Foo-x @J-Fields