Fix: Add border to search decorations #8722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryclee
changed the title
bryclee
changed the title
|
Thank you! |
J-Fields
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add border to search highlights, for themes that do not use background but use border instead to indicate find results
Which issue(s) this PR fixes
#7364
Special notes for your reviewer:
I saw some comments in the issue about refactoring the decoration, but as I don't have much context on the code, I went with the simple change to add the border as-is.
Screenshots using "Light High Contrast" theme:
Search (cursor is on line 1, run
/test, current match is on line 2):Search replace (cursor is on first word "that", running
:s/test/replace/g):Search append (cursor is on first word "test", running
:s/this/that/g):