fix: only create new file on split when specified #8733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure how to proper add tests for this behavior, will try submit one in the new pr. |
|
hi @J-Fields could you please take a look on this? Sorry for the ping, but the bug is quite annoying :( |
|
Any ETA on when this will be merged? |
pimpeters
approved these changes
Nov 22, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#8698 introduced support for creating new file on split. However, the create behavior should only be used when there is a file arg specified for the split command.
(v)sp(v)sp <file>#8698 fixed the 2nd case, while broke the 1st case.
Which issue(s) this PR fixes
#8730
Special notes for your reviewer: