Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement posteriors generator #162

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Implement posteriors generator #162

merged 4 commits into from
Sep 26, 2023

Conversation

camposandro
Copy link
Collaborator

Creates a script that enables the generation of posteriors using a variety of samplers.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #162 (2370433) into main (6dc9f47) will not change coverage.
The diff coverage is n/a.

❗ Current head 2370433 differs from pull request most recent head 1a90001. Consider uploading reports for the commit 1a90001 to get more accurate results

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   75.60%   75.60%           
=======================================
  Files          36       36           
  Lines        2919     2919           
=======================================
  Hits         2207     2207           
  Misses        712      712           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Before After Ratio Method
[6dc9f47] [ff9e07a]
12.5±0.04s 20.1±0s 1.61 sampling_suite.SamplingSuite.time_nuts_single_file
12.4±0.01s 12.5±0.09s 1.01 inference_suite.InferenceSuite.time_numpyro_nuts_inference
197±3ms 198±4ms 1.01 sampling_suite.SamplingSuite.time_licu_mcmc_ceres_single_file
11.6±0.02s 11.7±0.02s 1.01 sampling_suite.SamplingSuite.time_svi_single_file
7.85±0.01s 7.83±0s 1 sampling_suite.SamplingSuite.time_dynesty_single_file
11.6±0.02s 11.5±0.1s 1 inference_suite.InferenceSuite.time_numpyro_svi_inference
209±8ms 204±10ms 0.98 sampling_suite.SamplingSuite.time_iminuit_single_file
10.8±1ms 10.4±0.6ms 0.97 sampling_suite.SamplingSuite.time_licu_ceres_single_file
7.56±0.3s 7.04±0.04s 0.93 inference_suite.InferenceSuite.time_dynesty_inference

Click here to view all benchmarks.

@github-actions
Copy link

Before After Ratio Method
[6dc9f47] [34dc839]
11.4±1s 14.2±0.01s ~1.25 inference_suite.InferenceSuite.time_numpyro_nuts_inference
4.04±0.09s 4.21±0.08s 1.04 inference_suite.InferenceSuite.time_dynesty_inference
7.51±0.04s 7.59±0.02s 1.01 sampling_suite.SamplingSuite.time_svi_single_file
164±1ms 165±0.8ms 1.01 sampling_suite.SamplingSuite.time_licu_mcmc_ceres_single_file
7.59±0.03s 7.64±0.02s 1.01 inference_suite.InferenceSuite.time_numpyro_svi_inference
8.97±0.01ms 9.00±0.08ms 1.00 sampling_suite.SamplingSuite.time_licu_ceres_single_file
8.88±0s 8.91±0s 1.00 sampling_suite.SamplingSuite.time_nuts_single_file
3.81±0.02s 3.78±0.01s 0.99 sampling_suite.SamplingSuite.time_dynesty_single_file
123±0.4ms 122±0.3ms 0.99 sampling_suite.SamplingSuite.time_iminuit_single_file

Click here to view all benchmarks.

for sampler in [
"dynesty",
"svi",
# "NUTS",
Copy link
Collaborator Author

@camposandro camposandro Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out because NUTS is failing to compute samples. Opened #163 to address the issue.

@github-actions
Copy link

Before After Ratio Method
[6dc9f47] [1b51c9c]
175±0.2ms 183±8ms 1.05 sampling_suite.SamplingSuite.time_licu_mcmc_ceres_single_file
8.87±0.04s 9.01±0s 1.02 sampling_suite.SamplingSuite.time_svi_single_file
9.13±0.1ms 9.19±0.03ms 1.01 sampling_suite.SamplingSuite.time_licu_ceres_single_file
8.96±0.03s 8.99±0.04s 1.00 inference_suite.InferenceSuite.time_numpyro_svi_inference
124±0.8ms 125±0.4ms 1.00 sampling_suite.SamplingSuite.time_iminuit_single_file
4.29±0.05s 4.28±0.05s 1.00 sampling_suite.SamplingSuite.time_dynesty_single_file
4.74±0.07s 4.39±0.07s 0.93 inference_suite.InferenceSuite.time_dynesty_inference
16.3±0.06s 13.2±1s ~0.81 sampling_suite.SamplingSuite.time_nuts_single_file
13.1±2s 10.1±0s ~0.77 inference_suite.InferenceSuite.time_numpyro_nuts_inference

Click here to view all benchmarks.

@camposandro camposandro merged commit 91e5b55 into main Sep 26, 2023
@camposandro camposandro deleted the posteriors-generator branch September 26, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants