Allow images to be moved around the cropper area when zoom is less than 1 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, it's indeed a nice feature! I think it will be worth backporting it to the parent. React lib. |
ValentinH
reviewed
Jan 15, 2024
|
Thanks for the feedback, I moved the code and updated the +page.svelte so that it can be tested. Let me know if you have any comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a feature you're looking for in this package, but it has been useful in projects before. Feel free to reject.
Currently when zoom goes below 1 and the image becomes smaller than the cropper area the image stays glued to the top left corner of the cropper area. This update will make it so that when zoom drops below 1 the image can be moved around in the cropper area but no part of the image can be outside of it.
Where does this idea come from? When letting users upload logos, that will be displayed in a round avatar, in a SaaS product it can be useful to let users resize the logo smaller than the cropper area to fit more nicely in the round avatar.