Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual TDP being set too frequent #880

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

CasperH2O
Copy link
Collaborator

@CasperH2O CasperH2O commented Dec 14, 2023

Manual TDP was set every 1000 msec, in practice the SMU cannot handle faster then 1 Hz. Due to timing inaccuracies of the interval, sometimes this would be faster then 1000 msec, resulting odd issues like TDP not applying or worse, BSOD.

Side note, this is also what AutoTDP is set to 1010 msec.

Summary by CodeRabbit

  • Refactor
    • Adjusted the default interval for performance-related operations to enhance efficiency and reduce system load. Users may notice a slight change in the timing of these operations.

Manual TDP was set every 1000 msec, in practice the SMU cannot handle faster then 1 Hz. Due to timing inaccuracies of the interval, sometimes this would be faster then 1000 msec, resulting odd issues like TDP not applying or worse, BSOD.

Side note, this is also what AutoTDP is set to 1010 msec.
Copy link
Contributor

coderabbitai bot commented Dec 14, 2023

Walkthrough

The PerformanceManager within a software system has undergone an update to its operational timing. Specifically, the default interval for scanning values has been extended from 1 second to 3 seconds, potentially impacting the rhythm of performance checks and related tasks managed by this component.

Changes

File Summary
.../Managers/PerformanceManager.cs Default scan interval changed from 1000ms to 3000ms.

Poem

A hop, a skip, a timely leap,
Our scans are now less frequent, deep.
🕒 Three seconds pass, we check, we wait,
For performance tales that we create. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 25cc827 and 09b4cc2.
Files selected for processing (1)
  • HandheldCompanion/Managers/PerformanceManager.cs (2 hunks)
Additional comments: 3
HandheldCompanion/Managers/PerformanceManager.cs (3)
  • 35-37: The update to the INTERVAL_DEFAULT constant from 1000 to 3000 milliseconds aligns with the PR objective to mitigate issues with the SMU's handling of frequent TDP updates. This change should help avoid the timing inaccuracies that led to the TDP not being applied correctly or system crashes. Ensure that all related timers and operations that depend on this constant are tested to confirm that the new interval does not introduce any new issues.

  • 36-36: The INTERVAL_AUTO constant is set to 1010 milliseconds, which is slightly longer than the original 1000 milliseconds. This change is likely intended to avoid the timing issues mentioned in the PR objective. Verify that the autoWatchdog Timer, which uses this constant, functions correctly with the new interval and that it does not conflict with the manual TDP setting.

  • 37-37: The INTERVAL_DEGRADED constant is set to 5000 milliseconds. While this change is not mentioned in the PR objective or the AI-generated summary, it's important to ensure that the degraded mode interval is appropriate for the system's needs and does not negatively impact the user experience during degraded operation.

@CasperH2O CasperH2O merged commit 06129ea into Valkirie:main Dec 19, 2023
1 check passed
@CasperH2O CasperH2O deleted the FixTooLowTDPInterval branch February 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant