[REFERENCE] hotfix for new Legion Space update v1.0.2.5: Controller READY-byte an…

HandheldCompanion.iss

@@ -374,7 +374,7 @@ end;
 
 #define MyAppSetupName 'Handheld Companion'
 #define MyBuildId 'HandheldCompanion'
-#define MyAppVersion '0.19.1.6'
+#define MyAppVersion '0.19.1.7'
 #define MyAppPublisher 'BenjaminLSR'
 #define MyAppCopyright 'Copyright @ BenjaminLSR'
 #define MyAppURL 'https://github.com/Valkirie/HandheldCompanion'

HandheldCompanion/Controllers/LegionController.cs

@@ -42,6 +42,10 @@ private enum BackEnum
         private const byte BACK_IDX = 19;
         private const byte STATUS_IDX = 0;
         private const byte PING_IDX = 40;
+        private HashSet<int> READY_STATES = new HashSet<int>() {25, 60};
+
+        private const byte MIN_WIRELESS_STATUS = 40;
+        private const byte MAX_WIRELESS_STATUS = 50;
 
         private Thread dataThread;
         private bool dataThreadRunning;
@@ -52,16 +56,16 @@ public override bool IsReady
             get
             {
                 byte status = GetStatus(STATUS_IDX);
-                return status == 25;
+                return READY_STATES.Contains(status);
             }
         }
 
         public bool IsWireless
         {
             get
             {
-                byte status = GetStatus(PING_IDX);
-                return (status >= 40 && status <= 50);
+                byte status = GetStatus(PING_IDX);
+                return (status >= MIN_WIRELESS_STATUS && status <= MAX_WIRELESS_STATUS);
             }
         }
 
@@ -235,11 +239,12 @@ private async void dataThreadLoop(object? obj)
                 if (hidDevice is null)
                     continue;
 
-                HidReport report = hidDevice.ReadReport();
+                HidReport report = hidDevice.ReadReport();
+
                 if (report is not null)
                 {
                     // check if packet is safe
-                    if (report.Data[STATUS_IDX] == 25)
+                    if (READY_STATES.Contains(report.Data[STATUS_IDX]))
                         Data = report.Data;
                 }
             }
@@ -370,17 +375,9 @@ public void HandleTouchpadInput(bool touched, ushort x, ushort y)
 
         internal void SetPassthrough(bool enabled)
         {
-            switch(enabled)
-            {
-                case true:
-                    SetTouchPadStatus(1);
-                    break;
-                case false:
-                    SetTouchPadStatus(0);
-                    break;
-            }
-
+            SetTouchPadStatus(enabled ? 1 : 0);
             IsPassthrough = enabled;
         }
+
     }
 }

HandheldCompanion/Controls/Hints/Hint_LegionGoServices.cs

@@ -0,0 +1,107 @@
+using HandheldCompanion.Devices;
+using HandheldCompanion.Utils;
+using HandheldCompanion.Views;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.ServiceProcess;
+using System.Threading.Tasks;
+using System.Timers;
+using System.Windows;
+
+namespace HandheldCompanion.Controls.Hints
+{
+    public class Hint_LegionGoServices : IHint
+    {
+        private List<string> serviceNames = new()
+        {
+            "DAService",
+        };
+
+        private List<ServiceController> serviceControllers = new();
+        private Timer serviceTimer;
+
+        public Hint_LegionGoServices() : base()
+        {
+            if (MainWindow.CurrentDevice is not LegionGo)
+                return;
+
+            // Get all the services installed on the local computer
+            ServiceController[] services = ServiceController.GetServices();
+            foreach (string serviceName in serviceNames)
+            {
+                if (services.Any(s => serviceNames.Contains(s.ServiceName)))
+                {
+                    // Create a service controller object for the specified service
+                    ServiceController serviceController = new ServiceController(serviceName);
+                    serviceControllers.Add(serviceController);
+                }
+            }
+
+            // Check if any of the services in the list exist
+            if (!serviceControllers.Any())
+                return;
+
+            serviceTimer = new Timer(4000);
+            serviceTimer.Elapsed += ServiceTimer_Elapsed;
+            serviceTimer.Start();
+
+            // default state
+            this.HintActionButton.Visibility = Visibility.Visible;
+
+            this.HintTitle.Text = Properties.Resources.Hint_LegionGoServices;
+            this.HintDescription.Text = Properties.Resources.Hint_LegionGoServicesDesc;
+            this.HintReadMe.Text = Properties.Resources.Hint_LegionGoServicesReadme;
+
+            this.HintActionButton.Content = Properties.Resources.Hint_LegionGoServicesAction;
+        }
+
+        private void ServiceTimer_Elapsed(object? sender, ElapsedEventArgs e)
+        {
+            if(!serviceControllers.Any())
+                return;
+
+            // Check if any of the services in the list exist and are running
+            bool anyRunning = false;
+
+            foreach (ServiceController serviceController in serviceControllers)
+            {
+                serviceController.Refresh();
+                if (serviceController.Status == ServiceControllerStatus.Running)
+                {
+                    anyRunning = true;
+                    break;
+                }
+            }
+
+            // UI thread (async)
+            Application.Current.Dispatcher.BeginInvoke(() =>
+            {
+                this.Visibility = anyRunning ? Visibility.Visible : Visibility.Collapsed;
+            });
+        }
+
+        protected override void HintActionButton_Click(object sender, RoutedEventArgs e)
+        {
+            if (!serviceControllers.Any())
+                return;
+
+            Task.Run(async () =>
+            {
+                foreach (ServiceController serviceController in serviceControllers)
+                {
+                    if (serviceController.Status == ServiceControllerStatus.Running)
+                        serviceController.Stop();
+                    serviceController.WaitForStatus(ServiceControllerStatus.Stopped);
+                    ServiceUtils.ChangeStartMode(serviceController, ServiceStartMode.Disabled, out _);
+                }
+            });
+        }
+
+        public override void Stop()
+        {
+            serviceTimer.Stop();
+            base.Stop();
+        }
+    }
+}

HandheldCompanion/HandheldCompanion.csproj

@@ -12,7 +12,7 @@
     <StartupObject>HandheldCompanion.App</StartupObject>
     <OutputPath>$(SolutionDir)bin\$(Configuration)</OutputPath>
     <ApplicationIcon>Resources\icon.ico</ApplicationIcon>
-    <Version>0.19.1.6</Version>
+    <Version>0.19.1.7</Version>
     <ApplicationManifest>app.manifest</ApplicationManifest>
     <Platforms>AnyCPU;x64;x86</Platforms>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>

HandheldCompanion/Properties/Resources.resx

@@ -2673,4 +2673,16 @@ with motion input toggle, press selected button(s) to switch from enabled to dis
   <data name="DevicePage_FullFanSpeedText" xml:space="preserve">
     <value>Fan max speed override</value>
   </data>
+  <data name="Hint_LegionGoServices" xml:space="preserve">
+    <value>Legion Space Daemon is active</value>
+  </data>
+  <data name="Hint_LegionGoServicesAction" xml:space="preserve">
+    <value>Disable Legion Space Daemon</value>
+  </data>
+  <data name="Hint_LegionGoServicesDesc" xml:space="preserve">
+    <value>Legion Space Daemon is already active on your console. This may cause compatibility issues with the application.</value>
+  </data>
+  <data name="Hint_LegionGoServicesReadme" xml:space="preserve">
+    <value>You should disable Legion Space Daemon, so that the application can run properly and without any errors</value>
+  </data>
 </root>

HandheldCompanion/Views/Pages/NotificationsPage.xaml

@@ -55,6 +55,7 @@
         <ui:SimpleStackPanel Name="Notifications" Spacing="6">
 
             <hints:Hint_LegionGoDaemon d:Visibility="Visible" />
+            <hints:Hint_LegionGoServices d:Visibility="Visible" />
             <hints:Hint_RogAllyServiceCheck d:Visibility="Visible" />
             <hints:Hint_SteamNeptuneDesktop d:Visibility="Visible" />
             <hints:Hint_SteamXboxDrivers d:Visibility="Visible" />