Don't restart IMU on ROG Ally

[romracer]

Not needed since Bosch drivers 1.0.1.7 released many moons ago (mid-July). Might also not be needed on AYA NEO Air Plus if those drivers worked on that device, but I don't own one to test it.

Summary by CodeRabbit

• Refactor
  • Simplified device type handling by removing specific case for "ROGAlly".

[coderabbitai]

Walkthrough

The overall change involves simplifying the code by removing specific handling for a device type named "ROGAlly" from a switch case block in the MainWindow.xaml.cs file. This indicates a streamlining of the application's device compatibility or the discontinuation of special support for the "ROGAlly" device.

Changes

File Path	Change Summary
.../Views/Windows/MainWindow.xaml.cs	Removed case statement for "ROGAlly" in currentDeviceType switch block.

🐇✨
In the realm of code, where logic does play,
A case was removed, simplifying the day.
No more "ROGAlly", in the switch it does part,
A hop towards simplicity, straight from the heart.
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 10

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between b85593a and f7b50ea.

Files selected for processing (1)

• HandheldCompanion/Views/Windows/MainWindow.xaml.cs (1 hunks)

Additional comments: 1

HandheldCompanion/Views/Windows/MainWindow.xaml.cs (1)

• 183-188: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The PR description indicates the removal of a case statement for "ROGAlly" in a switch block, but the provided code does not highlight this change. Assuming the removal is correctly implemented, ensure that any logic or operations previously under the "ROGAlly" case are no longer necessary or have been appropriately refactored.

[CasperH2O]

@romracer we have completely removed the IMU restart from the code in the EA fork. Thanks for raising this item.

Would you be OK with closing this one?

[romracer]

@CasperH2O sure, glad to hear the Aya Neo Air Plus works too :)