Port fixes from: sarpy#508, sarpy#530, sarpy#538, sarpy#561; fix docs warning #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pressler-vsc
requested review from
mtrachy,
bombaci-vsc,
dhaverporth,
mstewart-vsc and
johnstob
johnstob
approved these changes
Dec 3, 2024
johnstob
approved these changes
Dec 3, 2024
bombaci-vsc
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ports 4 SARPy bugfixes relevant to SARkit's NITF handling:
In addition, a warning related to a mislabeled docstring section has been addressed.
Aside from some import path changing and ruff-formatting, the only novel difference from the original SARPy source was the omission of a unit-test for the changes related to ngageoint/sarpy#561. This is because the unittest introduced with the fix in SARPy relies on code that doesn't exist in SARPy2 and I couldn't think of an easy way to introduce a new test that wasn't brittle. I propose it is still better to bring over the code changes for commmonality with SARPy and that when legends/DEDs are added to SIDD I/O the code paths will be exercised.