Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed include problems and compilation errors #1558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maniform
Copy link

@Maniform Maniform commented Jun 4, 2021

  • Replaced bad include definitions
  • Define Format function as a Windows only
  • Removed AssertMsg and include assert which causes problems

I tested to compile on Windows 10 and Ubuntu 21.04 and it worked on both of them. I've noticed a bit too late that an other quite similar pull request has been asked here : [https://github.com//pull/1524]. I don't know if it's a problem or not.

- Replaced bad include definitions
- Define Format function as a Windows only
- Removed AssertMsg and include assert which causes problems
@okawo80085
Copy link

okawo80085 commented Aug 27, 2021

assert.h includes are not handled the best way, those asserts still serve a purpose and just removing them is not the best idea, but adding assert.h into vrcommon would break standard library assert.h includes.
So either add a file like assert<suffix>.h and in it define a simple print on assert function using static assert from the standard library assert.h
OR
Add assert.h but define a full fledged AssertMsg in it and add a define for assert since it is used in jsoncpp.cpp

@okawo80085
Copy link

Also you missed a stdarg.h include in strtools_public.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants