[FIX] default_warehouse_from_sale_team: usability for readonly users T#79454 #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisg123v
requested review from
desdelinux,
isaako34,
TeposteAJ and
rolandojduartem
Limited users are able to see some pickings in readonly mode, but there were some usability issues that are fixed in this commit: - It was possible to mark as TODo and check availability, because those actions don't require write access to the pickings. This is fixed by hiding involved buttons. - Even though validating a picking does require access, it's also hidden because there's no point on showing a button that can't be used anyway. - Similarly, the Print button is also hidden when the picking is not done yet, because it requires access to mark the picking as printed. - The Return button is also hidden. Even though it doesn't require write access to the current picking, it will require creation access on the new picking. - The Cancel button is not hidden because it requires being inventory administrator, which is not compatible with being a limited user.
luisg123v
force-pushed
the
17.0-default_warehouse_readonly_usability-luisg
branch
from
b54b51b to
8dc846c
Compare
TeposteAJ
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Hi @luisg123v , I agree with the proposal. The code looks good to me
|
LGTM 👍 |
rolandojduartem
approved these changes
Sep 5, 2024
luisg123v
deleted the
17.0-default_warehouse_readonly_usability-luisg
branch
luisg123v
restored the
17.0-default_warehouse_readonly_usability-luisg
branch
luisg123v
deleted the
17.0-default_warehouse_readonly_usability-luisg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited users are able to see some pickings in readonly mode, but there were some usability issues that are fixed in this commit:
Dummy MR: