build

build.properties

@@ -1,9 +1,9 @@
-#Sat Jun 01 15:50:12 UTC 2024
+#Sat Jun 01 18:18:10 UTC 2024
 mapping_version=1.20.1
 version=4.0
 mod_name=Quark
 mc_version=1.20.1
 mapping_channel=official
 mod_id=quark
-build_number=453
+build_number=454
 dir_output=../Build Output/Quark/

changelog.txt

@@ -1,9 +1,2 @@
-- Fixed pathfinder quill duplicating when used in offhand
-- Fixed magnets only pushing armor items
-- Fixed magnets pushing players regardless of whether they have armor or not
-- Rune colors are now extensible. Custom ones can be added by mods
-- Variant selector and rotation lock HUD overlays can now render similar to crosshair, Improving visibility in bright environments
-- You can now middle click a block to select it with variant selector, either when you have a variant block or a hammer in hand
-- Variant selector wheel wont appear anymore for blocks with no variants
-- Hammer won't play swing animation when it didn't change a variant
-- Fixed magnets not pulling certain magnetic items
+- Fixed a crash when middle clicking a block and having Variant Selector module off
+- Middle clicking a variant block while NOT having its parent variant in hand will now make you select the latter

src/main/java/org/violetmoon/quark/content/experimental/config/VariantsConfig.java

@@ -55,13 +55,13 @@ public class VariantsConfig implements IConfigType {
 	)
 	private List<String> blacklist = Arrays.asList("minecraft:snow", "minecraft:bamboo", "minecraft:bamboo_block");
 
-	private Map<Block, VariantMap> blockVariants = new HashMap<>();
-	private Map<Block, Block> originals = new HashMap<>();
-	private Multimap<String, String> aliasMap = HashMultimap.create();
-	private Multimap<Block, ManualVariant> manualVariantMap = HashMultimap.create();
+	private final Map<Block, VariantMap> blockVariants = new HashMap<>();
+	private final Map<Block, Block> originals = new HashMap<>();
+	private final Multimap<String, String> aliasMap = HashMultimap.create();
+	private final Multimap<Block, ManualVariant> manualVariantMap = HashMultimap.create();
 
-	private List<String> visibleVariants = new ArrayList<>();
-	private List<String> sortedSuffixes;
+	private final List<String> visibleVariants = new ArrayList<>();
+	private final List<String> sortedSuffixes = new ArrayList<>();
 
 	public VariantsConfig() {}
 
@@ -72,14 +72,15 @@ public void onReload(ZetaModule module, ConfigFlagManager flagManager) {
 		originals.clear();
 		aliasMap.clear();
 		manualVariantMap.clear();
+		sortedSuffixes.clear();
 
 		if(module != null && !module.enabled)
 			return;
 
 		for(String s : variantTypes)
 			visibleVariants.add(s.replaceAll("!", ""));
 
-		sortedSuffixes = new ArrayList<>(visibleVariants);
+		sortedSuffixes.addAll(visibleVariants);
 		sortedSuffixes.sort((s1, s2) -> { // sort by amount of _
 			int ct1 = s1.replaceAll("[^_]", "").length();
 			int ct2 = s2.replaceAll("[^_]", "").length();