Skip to content

Replace BnStrCompatible with AsCStr trait #284

Replace BnStrCompatible with AsCStr trait

Replace BnStrCompatible with AsCStr trait #284

Triggered via pull request January 23, 2025 16:15
Status Failure
Total duration 45m 42s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Deployment protection rules

Reviewers, timers, and other rules protecting deployments in this run
Event Environments Comment
emesare
approved Jan 23, 2025
testing

LGTM

Annotations

6 errors and 9 warnings
typos
Process completed with exit code 2.
the following explicit lifetimes could be elided: 'a: rust/rust/src/ffi.rs#L61
error: the following explicit lifetimes could be elided: 'a --> ./rust/rust/src/ffi.rs:61:21 | 61 | fn next_subpart<'a>(&'a mut self) -> Option<Self::Progress<'a>>; | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-D clippy::needless-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 61 - fn next_subpart<'a>(&'a mut self) -> Option<Self::Progress<'a>>; 61 + fn next_subpart(&mut self) -> Option<Self::Progress<'_>>; |
the following explicit lifetimes could be elided: 'a: rust/rust/src/ffi.rs#L144
error: the following explicit lifetimes could be elided: 'a --> ./rust/rust/src/ffi.rs:144:21 | 144 | fn next_subpart<'a>(&'a mut self) -> Option<Self::Progress<'a>> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 144 - fn next_subpart<'a>(&'a mut self) -> Option<Self::Progress<'a>> { 144 + fn next_subpart(&mut self) -> Option<Self::Progress<'_>> { |
the following explicit lifetimes could be elided: 'a: rust/rust/src/ffi.rs#L153
error: the following explicit lifetimes could be elided: 'a --> ./rust/rust/src/ffi.rs:153:6 | 153 | impl<'a, P: ProgressCallback> Drop for SplitProgressInstance<'a, P> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 153 - impl<'a, P: ProgressCallback> Drop for SplitProgressInstance<'a, P> { 153 + impl<P: ProgressCallback> Drop for SplitProgressInstance<'_, P> { |
the following explicit lifetimes could be elided: 'a: rust/rust/src/ffi.rs#L160
error: the following explicit lifetimes could be elided: 'a --> ./rust/rust/src/ffi.rs:160:6 | 160 | impl<'a, P: ProgressCallback> ProgressCallback for SplitProgressInstance<'a, P> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 160 - impl<'a, P: ProgressCallback> ProgressCallback for SplitProgressInstance<'a, P> { 160 + impl<P: ProgressCallback> ProgressCallback for SplitProgressInstance<'_, P> { |
cargo clippy
Error: Clippy has exited with exit code 101
typos: rust/src/collaboration/snapshot.rs#L134
"entires" should be "entries".
typos: rust/src/collaboration/snapshot.rs#L183
"entires" should be "entries".
typos: rust/src/collaboration/snapshot.rs#L198
"entires" should be "entries".
typos: rust/src/collaboration/remote.rs#L217
"loggin" should be "login" or "logging".
typos: rust/src/collaboration/remote.rs#L224
"loggin" should be "login" or "logging".
typos: rust/src/collaboration/file.rs#L325
"droping" should be "dropping".
cargo fmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
cargo clippy
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
cargo test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636