-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rxrx1 research running scripts #309
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks nearly ready to go. Most of my comments are minor. Only question of import that we want to consider is the optimizer setup (and consistency for FedAvg vs. the other approaches).
research/rxrx1/data/dataset.py
Outdated
transform: Callable | None = None, | ||
cache_images: bool = False, | ||
): | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of this descriptor, maybe we can have a small blurb about how one retrieves this dataset? That is, a url from which to download it (or however else it should be obtained) along with any processing steps that need to happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will add a README to dataset section
PR Type
[Other]
Short Description
Add running script for rxrx1 dataset. This dataset has natural feature heterogeneity among 4 clients.
Tests Added
NA