Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rxrx1 research running scripts #309

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Rxrx1 research running scripts #309

wants to merge 19 commits into from

Conversation

sanaAyrml
Copy link
Collaborator

@sanaAyrml sanaAyrml commented Jan 6, 2025

PR Type

[Other]

Short Description

Add running script for rxrx1 dataset. This dataset has natural feature heterogeneity among 4 clients.

Tests Added

NA

@sanaAyrml sanaAyrml marked this pull request as draft January 6, 2025 18:22
@sanaAyrml sanaAyrml changed the title Sa rxrx1 research Rxrx1 research running scripts Jan 9, 2025
@sanaAyrml sanaAyrml marked this pull request as ready for review January 9, 2025 12:02
@sanaAyrml sanaAyrml requested a review from emersodb January 9, 2025 12:02
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks nearly ready to go. Most of my comments are minor. Only question of import that we want to consider is the optimizer setup (and consistency for FedAvg vs. the other approaches).

research/rxrx1/data/data_utils.py Outdated Show resolved Hide resolved
research/rxrx1/data/data_utils.py Outdated Show resolved Hide resolved
research/rxrx1/data/data_utils.py Outdated Show resolved Hide resolved
research/rxrx1/data/data_utils.py Outdated Show resolved Hide resolved
research/rxrx1/data/dataset.py Outdated Show resolved Hide resolved
research/rxrx1/utils.py Show resolved Hide resolved
research/rxrx1/utils.py Outdated Show resolved Hide resolved
research/rxrx1/evaluate_on_test.py Show resolved Hide resolved
research/rxrx1/evaluate_on_test.py Outdated Show resolved Hide resolved
transform: Callable | None = None,
cache_images: bool = False,
):
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this descriptor, maybe we can have a small blurb about how one retrieves this dataset? That is, a url from which to download it (or however else it should be obtained) along with any processing steps that need to happen?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I will add a README to dataset section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants