-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup our docs and host to github pages [CU-868byp419] #313
Setup our docs and host to github pages [CU-868byp419] #313
Conversation
Task linked: CU-868byp419 Initial setup for docs |
c6d587e
to
088f5b9
Compare
25683fa
to
63a7032
Compare
99db989
to
692e683
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, awesome PR...really looking forward to fixing all the documentation rendering warning that are surfaced by this 😂
Just a few small comments and some rendering issues I ran into for whatever reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you're good with my condensation of the quickstart, I'm good for this to go in.
More than happy with it! Thanks for doing that. |
PR Type
Documentation
Short Description
This PR is big (sorry!) but is meant for setting up the docs and its associated processes for development and building/publishing. This PR is less focused on the particular content and sections in the docs, as this is something we should expect to continuously iterate on.
Specifically, what's included:
docs/
: a new directory containing our docs artifacts.github/workflows/docs_build.yml
for CI/CD build of our docs.github/workflows/docs_publish.yml
for CI/CD build of our docsgithub_pages
and will always reflect what's the latest in ourmain
branch. In a future PR, we may want to have docs built on our releases so that we can distinguish betweenstable
andlatest
versions of docs.Building and serving the docs locally:
poetry install --with docs cd docs make serve
The above will build the docs artifacts and serve them in
http://127.0.0.1:8000/
As the image above shows, the current content of docs includes:
Future PRs:
module guides
(this is probably a bunch of PRs, tbh) clickupexamples
(again, this is probably a bunch of PRs) clickupquickstart
-- this is a bit big, and scary in terms of imports for a "quickstart" clickupFor Reviewers:
For this PR, you may find it very helpful to actually checkout this branch and build/serve the docs locally on your machine. In case you're not using this already, I find the
gh
cli tool to be very helpful for checking out branches associated to a PR.After installing you can click the pulldown menu for "Code" at the top of this PR:
And copy and paste the command to checkout this branch on your local machine: