Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup our docs and host to github pages [CU-868byp419] #313

Merged
merged 23 commits into from
Jan 28, 2025

Conversation

nerdai
Copy link
Collaborator

@nerdai nerdai commented Jan 14, 2025

PR Type

Documentation

Short Description

This PR is big (sorry!) but is meant for setting up the docs and its associated processes for development and building/publishing. This PR is less focused on the particular content and sections in the docs, as this is something we should expect to continuously iterate on.

Specifically, what's included:

  • docs/: a new directory containing our docs artifacts
  • .github/workflows/docs_build.yml for CI/CD build of our docs
  • .github/workflows/docs_publish.yml for CI/CD build of our docs
    • Note: our docs will be published from the branch github_pages and will always reflect what's the latest in our main branch. In a future PR, we may want to have docs built on our releases so that we can distinguish between stable and latest versions of docs.

Building and serving the docs locally:

poetry install --with docs
cd docs
make serve

The above will build the docs artifacts and serve them in http://127.0.0.1:8000/

image

As the image above shows, the current content of docs includes:

  • Intro (home page)
  • Quickstart
  • Module Guides (Incomplete)
  • Examples (Incomplete)
  • API Reference

Future PRs:

  1. Add content to module guides (this is probably a bunch of PRs, tbh) clickup
  2. Add content to examples (again, this is probably a bunch of PRs) clickup
  3. Revise the content in quickstart -- this is a bit big, and scary in terms of imports for a "quickstart" clickup

For Reviewers:

For this PR, you may find it very helpful to actually checkout this branch and build/serve the docs locally on your machine. In case you're not using this already, I find the gh cli tool to be very helpful for checking out branches associated to a PR.

# install gh cli
brew install gh

After installing you can click the pulldown menu for "Code" at the top of this PR:

image

And copy and paste the command to checkout this branch on your local machine:

gh pr checkout 313

@vector-admin
Copy link

Task linked: CU-868byp419 Initial setup for docs

@nerdai nerdai force-pushed the CU-868byp419_Initial-setup-for-docs_Val-Andrei-Fajardo branch from c6d587e to 088f5b9 Compare January 22, 2025 17:23
@nerdai nerdai changed the title [CU-868byp419] Setup docs Setup our docs and host to github pages [CU-868byp419] Jan 22, 2025
@nerdai nerdai force-pushed the CU-868byp419_Initial-setup-for-docs_Val-Andrei-Fajardo branch from 25683fa to 63a7032 Compare January 27, 2025 18:33
@nerdai nerdai linked an issue Jan 27, 2025 that may be closed by this pull request
4 tasks
@nerdai nerdai marked this pull request as ready for review January 28, 2025 18:14
@nerdai nerdai requested a review from emersodb January 28, 2025 18:25
@emersodb emersodb requested review from sanaAyrml and lotif January 28, 2025 18:42
@nerdai nerdai force-pushed the CU-868byp419_Initial-setup-for-docs_Val-Andrei-Fajardo branch from 99db989 to 692e683 Compare January 28, 2025 20:43
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, awesome PR...really looking forward to fixing all the documentation rendering warning that are surfaced by this 😂

Just a few small comments and some rendering issues I ran into for whatever reason.

.github/workflows/docs_publish.yml Outdated Show resolved Hide resolved
docs/source/quickstart.md Outdated Show resolved Hide resolved
docs/source/quickstart.md Show resolved Hide resolved
docs/source/quickstart.md Outdated Show resolved Hide resolved
docs/source/quickstart.md Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/index.md Show resolved Hide resolved
docs/source/_templates/page.html Show resolved Hide resolved
docs/source/conf.py Show resolved Hide resolved
docs/source/quickstart.md Show resolved Hide resolved
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you're good with my condensation of the quickstart, I'm good for this to go in.

@nerdai
Copy link
Collaborator Author

nerdai commented Jan 28, 2025

Assuming you're good with my condensation of the quickstart, I'm good for this to go in.

More than happy with it! Thanks for doing that.

@nerdai nerdai merged commit 7839b82 into main Jan 28, 2025
7 checks passed
@nerdai nerdai deleted the CU-868byp419_Initial-setup-for-docs_Val-Andrei-Fajardo branch January 28, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap Docs
3 participants