Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Try fix stack-too-deep #1319

Merged
merged 1 commit into from
Jan 25, 2025
Merged

♻️ Try fix stack-too-deep #1319

merged 1 commit into from
Jan 25, 2025

Conversation

Vectorized
Copy link
Owner

Description

♻️

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link

Gas Snapshot Comparison Report

Generated at commit : d1551cf, Compared to commit : d355d14

Contract Name Test Name Main Gas PR Gas Diff
SafeTransferLibTest testApproveWithMissingReturn() 32633 32677 44
testApproveWithNonContractReverts() 6945 6879 -66
testApproveWithRetry() 789995 789952 -43
testApproveWithRetryWithNonContractReverts() 7312 7356 44
testApproveWithReturnsFalseReverts() 10230 10274 44
testApproveWithReturnsTooLittleReverts() 10179 10156 -23
testApproveWithReturnsTooMuch() 32891 32913 22
testApproveWithRevertingReverts() 10158 10202 44
testApproveWithStandardERC20() 32367 32411 44
testBalanceOfStandardERC20() 7808 7830 22
testForceTransferETHToGriever() 1511898 1511560 -338
testPermit2() 90147 90346 199
testPermit2AnythingWithNonContractReverts() 124808 125148 340
testPermit2OnDAI() 110315 110955 640
testSimplePermit2AndPermit2TransferFrom() 1135838 1145458 9620
testSimplePermit2AndPermit2TransferFromGas() 141416 141593 177
testTotalSupplyQuery() 27412 27433 21
testTransferAllETHToContractWithoutFallbackReverts() 10815 10837 22
testTransferAllFromWithStandardERC20() 33740 33695 -45
testTransferAllWithStandardERC20() 30966 30988 22
testTransferETH() 34622 34644 22
testTransferETHToContractWithoutFallbackReverts() 10872 10894 22
testTransferFromWithMissingReturn() 1299707 623138 -676569
testTransferFromWithNonContractReverts() 8140 8097 -43
testTransferFromWithReturnsFalseReverts() 588565 589585 1020
testTransferFromWithReturnsTooLittleReverts() 588568 589506 938
testTransferFromWithReturnsTooMuch() 623191 624108 917
testTransferFromWithRevertingReverts() 581020 582533 1513
testTransferFromWithStandardERC20() 621254 622362 1108
testTransferWithMissingReturn() 608949 610220 1271
testTransferWithNonContractReverts() 6908 6885 -23
testTransferWithReturnsFalseReverts() 585586 586671 1085
testTransferWithReturnsTooLittleReverts() 585451 586540 1089
testTransferWithReturnsTooMuch() 609512 610557 1045
testTransferWithRevertingReverts() 585580 586630 1050
testTransferWithStandardERC20() 609602 610301 699
testTryTransferAllETH() 148720 148742 22
testTryTransferETH() 148701 148723 22
testTryTransferETHWithNoGrief() 537047 537069 22
testTryTransferETHWithNoStorageWrites() 192466 192488 22
test__codesize() 71645 71735 90

@Vectorized Vectorized merged commit ed83a2a into main Jan 25, 2025
15 checks passed
@Vectorized Vectorized deleted the fix-via-ir branch January 25, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant