⚡️ Optimize SafeCastLib again #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `testSafeCastUint256ToIntBench` function and update .gas-snapshot A new function, testSafeCastUint256ToIntBench, was added for testing uint256 to int conversion. Also, .gas-snapshot file was updated to reflect changes in gas usage. * Optimize `SafeCastLib` further The check for overflow in the SafeCastLib library's typecasting functions was refactored. The conditions for triggering overflow and typecasting were reversed to improve code readability and understanding. The updated statements are also more efficient by avoiding unnecessary shift operations. * Optimize runtime gas for large optimizer runs * Refactor and optimize `toInt256` * Refactor and optimize `toUint256`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continued from #929.
Update: looks like the code is optimal in bytecode size and runtime gas for large number of optimizer runs.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.