Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new features): adds features, read pr for details #9

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

sadan4
Copy link

@sadan4 sadan4 commented Aug 18, 2024

Needs review

needs to be merged with the matching pr in the vencord repo

if you have any ideas for features, ping me on discord

current planned features

src/extension.ts Outdated
Comment on lines 20 to 27
workspace.registerTextDocumentContentProvider("vencord-companion", {
async provideTextDocumentContent(uri) {
console.log(uri)
//FIXME: full uri shows up in title bar
const newLocal = Buffer.from(uri.path.substring(1, uri.path.lastIndexOf(".")), "base64url");
return newLocal.toString()
},
}),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a really bad way to create a diff between two strings, but I tried for like a few hours and I couldn't figure out any other way

sadan4 and others added 22 commits August 21, 2024 01:42
fix types
fix button not being a button element
fix some crazy c# formatting (thanks sam)
add function to a lot of the buttons
fix dev env on the webview
prob something else as well
fix types
fix button not being a button element
fix some crazy c# formatting (thanks sam)
add function to a lot of the buttons
fix dev env on the webview
prob something else as well
update esbuild
update build system
add webview to normal build system
update scripts compile => build
@sadan4
Copy link
Author

sadan4 commented Aug 30, 2024

I think all the features are done, but this is still nowhere near ready
things that I know need review

  • the URI system for opening files from text
  • the build system

review is appreciated from whoever offers it

@sadan4 sadan4 marked this pull request as ready for review August 30, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants