feat(rpc): implement arrpc's link event
#1016
Conversation
This implements deep links from web so message links and the like work over just invites work. Depends on OpenAsar/arrpc/pull/128
|
this still doesn't work.. it still only switches to the window when i open a discord:// link that is supposed to jump to a message, but when i open a message link in the browser and then press open in discord it doesnt do anything |
|
You obviously misunderstand how to test this PR and the URI one. |
src/main/arrpc.ts
Outdated
| @@ -30,6 +30,9 @@ export async function initArRPC() { | |||
| .executeJavaScript(`Vesktop.openInviteModal(${JSON.stringify(invite)})`) | |||
| .then(callback); | |||
| }); | |||
| server.on("link", (data: any, deep_callback: (valid: boolean) => void) => { | |||
| mainWin.webContents.executeJavaScript(`Vesktop.openDeepLink(${JSON.stringify(data)})`).then(deep_callback); | |||
There was a problem hiding this comment.
i know you copy pasted this from the invite but I will add proper IPC that isn't just eval to main and then you can switch ur PR to that
This implements deep links from web so message links and the like work over just invites working.
Depends on OpenAsar/arrpc/pull/128
I noticed we didn't implement this after double checking what I said in a #813 comment
note: you need to be signed out of web for discord to prompt you for this