Changed icon size from 1080x1080 to 512x512 #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icon file size was changed to 512x512 as recommended in electron builder's documentation regarding icon size
3 tasks
|
did you mean to replace the icon in build/ instead? |
Changing the size of the icon in build/ unfortunately doesn't fix the issue. Could it be as icons are sourced from static/ here that the electron-builder is ignoring icons in build/ for linux builds |
|
the icon in static is only used for tray, nothing else the icon used in build is the one used as application icon |
|
That makes sense, would it be okay to reduce the tray icon size? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon file size was changed to 512x512 as recommended in the electron builder's documentation regarding icon size.
This addresses the #600 issue regarding broken icon size in the Debian 12 LXDE desktop environment.
The icon size electron builder recommends for all platforms is 212x212 or 512x512.
https://www.electron.build/icons.html